Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: for cache, notfound placeholder should not overwrite real data. #2960

Merged
merged 1 commit into from
Mar 4, 2023
Merged

fix: for cache, notfound placeholder should not overwrite real data. #2960

merged 1 commit into from
Mar 4, 2023

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Mar 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 3, 2023 •
edited
Loading

Codecov Report

Merging #2960 (3ac97b0) into master (dbc8f9f) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
core/stores/cache/cachenode.go 45.57% <0.00%> (-0.32%) ⬇️
core/syncx/spinlock.go 62.50% <0.00%> (-37.50%) ⬇️
core/stores/sqlx/tx.go 19.41% <0.00%> (-3.89%) ⬇️
core/logx/rotatelogger.go 71.58% <0.00%> (-2.22%) ⬇️
core/stores/sqlx/sqlconn.go 57.84% <0.00%> (+1.47%) ⬆️
zrpc/internal/balancer/p2c/p2c.go 93.44% <0.00%> (+2.45%) ⬆️

@kevwan kevwan force-pushed the feat/cache-setnxex branch 2 times, most recently from 4956128 to 613fd3c Compare March 4, 2023 11:46
@kevwan kevwan merged commit d953675 into zeromicro:master Mar 4, 2023
@kevwan kevwan deleted the feat/cache-setnxex branch March 4, 2023 12:34
kevwan added a commit that referenced this pull request Mar 4, 2023
@kevwan
chore: add tests (#2960)
9e0e01b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kevwan