Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zrpc): remove default keepalive params for NewClientWithTarget #3208

Merged
merged 1 commit into from
May 5, 2023
Merged

fix(zrpc): remove default keepalive params for NewClientWithTarget #3208

merged 1 commit into from
May 5, 2023

Conversation

zcong1993
Copy link
Member

fix #3139

@zcong1993 zcong1993 requested a review from kevwan May 5, 2023 12:53
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #3208 (f28f10a) into master (8a043d2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
zrpc/client.go 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@zcong1993 zcong1993 mentioned this pull request May 5, 2023
Closed
@kevwan kevwan added this pull request to the merge queue May 5, 2023
Merged via the queue into zeromicro:master with commit 8ad0668 May 5, 2023
6 checks passed
@zcong1993 zcong1993 deleted the fix-keepalive branch May 5, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

receiving a GOAWAY with error code ENHANCE_YOUR_CALM when call a long-running rpc method
2 participants
@zcong1993 @kevwan