Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method label for prometheus middleware metrics #3226

Merged
merged 2 commits into from
May 8, 2023
Merged

Add method label for prometheus middleware metrics #3226

merged 2 commits into from
May 8, 2023

Conversation

SleeplessBot
Copy link
Contributor

Add 'method' label for prometheus middleware metrics to resolve issue #3076

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #3226 (d4b9507) into master (9f42eda) will not change coverage.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
rest/engine.go 93.88% <100.00%> (ø)
rest/handler/prometheushandler.go 100.00% <100.00%> (ø)

@kevwan kevwan added this pull request to the merge queue May 8, 2023
Merged via the queue into zeromicro:master with commit a93c24c May 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SleeplessBot @kevwan @pubalglib