fix: fixed goctl api go --home parameter error when loading non-exist…

[elza2]

Describe the bug

goctl api go -api ./api/apis/hello.api --dir ./app --home ./api/.goctl

app/etc/test-api.yaml exists, ignored generation
app/internal/config/config.go exists, ignored generation
app/test.go exists, ignored generation
app/internal/svc/servicecontext.go exists, ignored generation
2023/06/05 11:57:01 open api/.goctl/1.5.3/api: no such file or directory

the 1.5.3 path is inexplicably found in the file path, causing the generation failure.
By viewing the goctl source code, find the tools/goctl/util/pathx/file.go 148 line, beforeTemplateDir does not exist.

 beforeTemplateDir := filepath.Join(home, version.GetGoctlVersion(), category)
 entries, err := os.ReadDir(beforeTemplateDir)
 if err != nil {
	return "", err
 }

The original code submission history for comparison found that err is not processed, is ignored.
After modification, the run was found to be successful.

goctl api go -api ./api/apis/hello.api --dir ./app --home ./api/.goctl

app/etc/test-api.yaml exists, ignored generation
app/internal/config/config.go exists, ignored generation
app/test.go exists, ignored generation
app/internal/svc/servicecontext.go exists, ignored generation
Done.

[lxy1992]

I meet this same problem today, but I suggest to fix this problem in a positive way.

[codecov]

Codecov Report

Merging #3319 (45a55c2) into master (2831432) will decrease coverage by 0.02%.
The diff coverage is n/a.

see 1 file with indirect coverage changes

[kesonan]

Please fix the error in loop at https://github.com/zeromicro/go-zero/blob/master/tools/goctl/util/pathx/file.go#L155 as follows:

for _, entry := range entries {
	info, err := entry.Info()
	if err != nil {
		continue
	}
	infos = append(infos, info)
}

[elza2]

Please fix the error in loop at https://github.com/zeromicro/go-zero/blob/master/tools/goctl/util/pathx/file.go#L155 as follows:

for _, entry := range entries {
	info, err := entry.Info()
	if err != nil {
		continue
	}
	infos = append(infos, info)
}

Hi, it has been repaired, please check it.

[elza2]

Please fix the error in loop at https://github.com/zeromicro/go-zero/blob/master/tools/goctl/util/pathx/file.go#L155 as follows:

for _, entry := range entries {
	info, err := entry.Info()
	if err != nil {
		continue
	}
	infos = append(infos, info)
}

Hi, it has been repaired, please check it.

@anqiansong

[kesonan]

LGTM