Fix: logx with Compress auto delete old logs #3329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the Windows operating system, if the Compress field of the logx component is set to true, the original uncompressed logs will not be automatically deleted.
This condition could NOT happen under Linux/Centos system.
Description:
logx has a function "gzipFile" in "go-zero/core/logx/rotatelogger.go", this function use "defer in.Close()" to close "in". But before that, "os.Remove(file)" want to delete this file, so it throws an exception "compress error: remove logs/error.log-2023-06-08:The process cannot access the file because it is being used by another process"
Solution:
I change "defer in.Close()" to "in.Close()" and put this code before "return os.Remove(file)" will fix this bug.
The code is:
OS: windows 10
go-zero version 1.4.0