Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add detail type mismatch info in number fields check (#3386) #3387

Merged
merged 2 commits into from
Jul 11, 2023
Merged

feat: add detail type mismatch info in number fields check (#3386) #3387

merged 2 commits into from
Jul 11, 2023

Conversation

lxy1992
Copy link
Contributor

@lxy1992 lxy1992 commented Jun 30, 2023 •
edited

add a feature I proposed in #3386

@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited

Codecov Report

Merging #3387 (02a5c02) into master (7d4fce9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 02a5c02 differs from pull request most recent head 64dcc0e. Consider uploading reports for the commit 64dcc0e to get more accurate results

Impacted Files Coverage Δ
core/mapping/unmarshaler.go 96.36% <100.00%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes

@chenquan
Copy link
Member

chenquan commented Jul 2, 2023

Thank you very much for your PR, please add more test cases.

@lxy1992
Copy link
Contributor Author

lxy1992 commented Jul 2, 2023

Ok, will do it today, thanks for reply

@lxy1992
Copy link
Contributor Author

lxy1992 commented Jul 4, 2023

@chenquan I have add a UT for this function, the coverage is go up

@lxy1992 lxy1992 force-pushed the 400-type-error branch 2 times, most recently from bb625b4 to 0171d13 Compare July 4, 2023 09:50
@zcong1993
Copy link
Member

@chenquan I have add a UT for this function, the coverage is go up

can you add some non primitive type mismatch cases in UT？

@kevwan kevwan added this pull request to the merge queue Jul 11, 2023
Merged via the queue into zeromicro:master with commit b9c0c0f Jul 11, 2023
5 checks passed
@p-linnane p-linnane mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lxy1992 @chenquan @zcong1993 @kevwan