Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1. Fix w. (http. Flusher). Flush() error #3388

Merged
merged 1 commit into from
Jul 5, 2023
Merged

1. Fix w. (http. Flusher). Flush() error #3388

merged 1 commit into from
Jul 5, 2023

Conversation

u2nyakim
Copy link
Contributor

#3375 The error caused no output and the request header setting did not take effect. The push submission has fixed this error and tested it 。

@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited

Codecov Report

Merging #3388 (d30ff04) into master (a86942d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
rest/handler/timeouthandler.go 97.72% <100.00%> (+0.10%) ⬆️

... and 2 files with indirect coverage changes

@kevwan kevwan added this pull request to the merge queue Jul 5, 2023
Merged via the queue into zeromicro:master with commit 916cea8 Jul 5, 2023
7 checks passed
This was linked to issues Jul 7, 2023
只要使用 w.(http.Flusher).Flush()，response header就会被重置 #3375
Closed
http.ResponseWriter Flush not work #3347
Closed
@kevwan kevwan mentioned this pull request Jul 11, 2023
Closed
@p-linnane p-linnane mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

只要使用 w.(http.Flusher).Flush()，response header就会被重置 http.ResponseWriter Flush not work
2 participants
@u2nyakim @kevwan