Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #3478 #3493

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix: #3478 #3493

merged 2 commits into from
Aug 14, 2023

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Aug 13, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #3493 (4d423be) into master (45fbd7d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Files Changed Coverage Δ
rest/httpx/requests.go 100.00% <ø> (ø)
core/mapping/unmarshaler.go 96.41% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

@kevwan kevwan requested a review from MarkJoyMa August 13, 2023 15:51
@MarkJoyMa
Copy link
Collaborator

LGTM

@kevwan kevwan added this pull request to the merge queue Aug 14, 2023
Merged via the queue into zeromicro:master with commit cb3ffc7 Aug 14, 2023
7 checks passed
@kevwan kevwan deleted the feat/rest-opaque-keys branch August 14, 2023 14:22
@kevwan kevwan linked an issue Aug 14, 2023 that may be closed by this pull request
Dot(.) char is not working in HTTP GET query tags. #3478
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkJoyMa MarkJoyMa MarkJoyMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dot(.) char is not working in HTTP GET query tags.
2 participants
@kevwan @MarkJoyMa