Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: limit logBrief http body size #3498

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

Awadabang
Copy link
Contributor

@Awadabang Awadabang commented Aug 16, 2023

It seems unnecessary to dump full Http Body to logBrief.
This PR move limitBodyBytes to top layer using. This ensures that the size of the http body passed to logBrief has been limited.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #3498 (f0807d8) into master (b22ad50) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Files Changed Coverage Δ
core/iox/read.go 90.00% <100.00%> (+0.71%) ⬆️
core/iox/tee.go 100.00% <100.00%> (ø)
rest/handler/loghandler.go 100.00% <100.00%> (+2.09%) ⬆️

... and 2 files with indirect coverage changes

@Awadabang Awadabang force-pushed the update/logHandler branch 3 times, most recently from fc6783c to 711ab46 Compare August 25, 2023 01:08
@Awadabang Awadabang force-pushed the update/logHandler branch 3 times, most recently from dca76dd to c24915a Compare September 12, 2023 13:52
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevwan kevwan added this pull request to the merge queue Sep 16, 2023
Merged via the queue into zeromicro:master with commit cc21f5f Sep 16, 2023
7 checks passed
@Awadabang Awadabang deleted the update/logHandler branch September 16, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants