Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: StopAgent panics when trace agent disabled #3981

Merged
merged 2 commits into from Mar 8, 2024
Merged

fix: StopAgent panics when trace agent disabled #3981

merged 2 commits into from Mar 8, 2024

Conversation

ansoda
Copy link
Contributor

@ansoda ansoda commented Mar 6, 2024

Close issue #3979

@kevwan kevwan self-requested a review March 7, 2024 03:22
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (2629636) to head (bb6ecea).
Report is 18 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
core/trace/agent.go 95.52% <100.00%> (-1.03%) ⬇️

... and 252 files with indirect coverage changes

@kevwan kevwan added this pull request to the merge queue Mar 8, 2024
Merged via the queue into zeromicro:master with commit 69bb746 Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ansoda @kevwan