Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: change err == xx to errors.Is(err, xx) #3991

Merged
merged 1 commit into from Mar 9, 2024

Conversation

mongobaba
Copy link
Contributor

Replace all error comparisons (matching format: err == xx) with errors.Is(err, xx).

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (2629636) to head (3cb0fbf).
Report is 21 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
core/iox/textlinescanner.go 100.00% <100.00%> (ø)
core/stores/redis/hook.go 100.00% <100.00%> (ø)
.../internal/clientinterceptors/tracinginterceptor.go 100.00% <100.00%> (ø)

... and 250 files with indirect coverage changes

@kevwan kevwan force-pushed the optimize_error_type_compare branch from 38b9b2d to 3cb0fbf Compare March 9, 2024 12:43
@kevwan kevwan added this pull request to the merge queue Mar 9, 2024
Merged via the queue into zeromicro:master with commit 459d302 Mar 9, 2024
6 checks passed
@mongobaba mongobaba deleted the optimize_error_type_compare branch March 9, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants