Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(httpx): support array field for request dto #4026

Conversation

shyandsy
Copy link
Contributor

@shyandsy shyandsy commented Mar 28, 2024

I would like to fix the array parsing issue
could you please to help check

#4025

image

image

@shyandsy shyandsy changed the title feature-4024: support array field for request dto fix(httpx): support array field for request dto Mar 28, 2024
@kevwan kevwan self-requested a review March 29, 2024 08:40
@kevwan kevwan added the area/restful Categorizes issue or PR as related to restful apis. label Mar 29, 2024
@kevwan
Copy link
Contributor

kevwan commented Mar 30, 2024

@shyandsy Thanks for your PR! I'll fix the test failure.

@kevwan kevwan merged commit 3ef59f6 into zeromicro:master Mar 30, 2024
4 of 5 checks passed
@kevwan kevwan linked an issue Mar 30, 2024 that may be closed by this pull request
@shyandsy
Copy link
Contributor Author

wow

first blood

@kevwan
Copy link
Contributor

kevwan commented Apr 4, 2024

I need to revert this PR. But with conflicts, I have to revert it manually in PR #4040

Check it out below:
#4025 (comment)

@shyandsy
Copy link
Contributor Author

shyandsy commented Apr 9, 2024

the structure is mass... let me rework on the solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/restful Categorizes issue or PR as related to restful apis.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support array field for Request DTO
2 participants