Move monitoring functionality out of socket_t and into monitor_t #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As already said in the other thread: In ØMQ 3.3 the notification messages consist of 2 parts. |
… guaranteed to get monitor events after this point. This is useful if you are spawning the monitor to a different thread and need to wait until monitor has started before opening the socket.
…ONITOR_STOPPED event.
|
Abort now implemented. |
Merged
|
Hello all Is there any reason why we couldn't merge this PR? Cheers |
|
Yes, that is correct. Just waiting for a maintainer to merge it, there doesn't seem to be a particularly active one for this project. |
|
Let's merge it then! |
kobolog
pushed a commit
that referenced
this pull request
Jul 16, 2013
Move monitoring functionality out of socket_t and into monitor_t
|
Thanks |
|
@ricnewton I've pushed you up to committer, take a look at http://rfc.zeromq.org/spec:22 which is our process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments on these changes in pull request 21: #21