-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ENABLE_DRAFTS option #565
base: master
Are you sure you want to change the base?
Remove ENABLE_DRAFTS option #565
Conversation
Pull Request Test Coverage Report for Build 6957349874
💛 - Coveralls |
This change will probably break something for someone using slightly older versions of libzmq. |
Yes, I would recommend merging this change only after a new release of libzmq (the commit in question is not part of a release yet), since it is fairly reasonable to expect people not to take a new version of cppzmq and an old version libzmq. |
This option added ZMQ_BUILD_DRAFT_API to the compile definitions. However, this should be propagated by libzmq (see zeromq/libzmq#4323 and zeromq#477). Signed-off-by: Stephan Lachnit <stephanlachnit@debian.org>
926f8c0
to
01bcc7d
Compare
@gummif since libzmq v4.3.5 has been released with zeromq/libzmq#4194 included, this can merged now |
I also updated the CI to use 4.3.5. to actually use this change. |
Sorry for the delay. I will see if I have time soon to do a review. |
@gummif friendly ping to check this :) This is quite a small change |
This option added ZMQ_BUILD_DRAFT_API to the compile definitions. However, this should be propagated by libzmq (see zeromq/libzmq#4323 and #477).
Closes #477.