Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary sha1.o in source tree and tarball #1042

Closed
bluca opened this issue Jul 23, 2015 · 10 comments
Closed

Binary sha1.o in source tree and tarball #1042

bluca opened this issue Jul 23, 2015 · 10 comments

Comments

@bluca
Copy link
Member

bluca commented Jul 23, 2015

Hello,

I am working on packaging CZMQ for Debian.

Is there any specific reason for https://github.com/zeromq/czmq/blob/master/src/foreign/sha1/sha1.o to be checked in the Git tree and distributed in the release tarballs? As far as I can see (and grep) there is no reference to the file anywhere.

Thank you!
Kind regards,
Luca Boccassi

@jemc
Copy link
Member

jemc commented Jul 23, 2015

No, there is no reason for it to be there. Care to open a PR that removes the file and adds it to .gitignore (if necessary)? Otherwise, I'll do it later this week.

@bluca
Copy link
Member Author

bluca commented Jul 23, 2015

I will do in a minute. Thank you :-)

bluca added a commit to bluca/czmq that referenced this issue Jul 23, 2015
@bluca
Copy link
Member Author

bluca commented Jul 23, 2015

Thanks for merging this. If I may ask, are there plans already for the next release?

Thank you!

@jemc
Copy link
Member

jemc commented Jul 24, 2015

@hintjens can probably do a patch release if this is blocking your progress.

@bluca
Copy link
Member Author

bluca commented Jul 24, 2015

Thanks, but fortunately it is not at the moment, because I found out that the tar.gz posted on http://download.zeromq.org/ is stripped from many build-related files and scripts, and the debian/watch file is pointed there rather than to Github. That tarball does not have the sha1.o.

Is it documented somewhere what is included in the tar.gz published on http://download.zeromq.org and what is excluded? Is there a script somewhere?

@Asmod4n
Copy link
Contributor

Asmod4n commented Jul 24, 2015

Most likely what is left after a make distclean

@bluca
Copy link
Member Author

bluca commented Jul 24, 2015

Mmh it doesn't look like, I tried running ./autogen.sh, ./configure and then make distclean but all the build-system files are still there.

@bluca
Copy link
Member Author

bluca commented Jul 27, 2015

@jemc @hintjens in case it doesn't happen normally, would it be possible to re-run ./generate.sh before the next release, if it's not too much trouble? Thanks!

@jemc
Copy link
Member

jemc commented Jul 27, 2015

@bluca see #1046

@bluca
Copy link
Member Author

bluca commented Jul 27, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants