-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS2015 build.bat has 'other' configuration entry names #1478
Comments
Hi, it comes from this file: https://github.com/zeromq/zproject/blob/master/zproject_vs20xx.gsl Could you please send a PR to fix it? Thanks! |
I'm not sure I can. There's some voodoo here I don't understand between the generator, GSL, and MSVC++. It seems like there's a mapping between these msbuild-compatible configuration/platform entries (eg, DynDebug|Win32) and the configuation/platform found in the .sln file (eg, DebugDLL|x86), but I must be misunderstanding how it works. |
Sorry, I'm really not familiar with MS build systems, hope someone else can chip in. |
The original MSVC projects are mine. I haven't looked at them closely since the migration to zproject. I'm traveling ATM and don't have the ability to review them, but can in a week or so. If you want a reference the libzmq projects should be nearly identical (sans zproject generation). |
I have also noticed this, now what I figured out is that the references are only invalid after you open the .sln file in VS2015 so it does something to update the .sln file to what it expects. Probably both the generation of the .sln file and .bat file need to be fixed. On a side note, the .bat file works fine if you don't actually open the solution. |
This issue has been automatically marked as stale because it has not had recent activity for 90 days. It will be closed if no further activity occurs within 21 days. Thank you for your contributions. |
The msvc/vs2015/build.bat file (and possibly the others) reference configurations that are invalid in the .sln file. I'm not sure where the zproject information that generates it comes from to even guess if it's just that the build.bat included in the repository is just old, or if zproject is generating an incorrect one.
The text was updated successfully, but these errors were encountered: