Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move randof() to become a real function #1746

Closed
jimklimov opened this issue Aug 7, 2017 · 1 comment
Closed

Move randof() to become a real function #1746

jimklimov opened this issue Aug 7, 2017 · 1 comment
Labels

Comments

@jimklimov
Copy link
Member

While the pieces of modular randof implementation got nicely spread around, the routine could benefit from becoming a real function (or a set of those) wrapping the same coding patterns and platform-dependent quirks. In particular, being a function would allow to better address run-time discrepancies between huge num range and a small RAND_MAX spectrum, as well as to compile changes once rather than require rebuild of CZMQ and whoever uses the header.

This issue is a sort of request for info: was there any special purpose to making it a macro rather than function in the first place?

@stale
Copy link

stale bot commented Nov 10, 2018

This issue has been automatically marked as stale because it has not had recent activity for 90 days. It will be closed if no further activity occurs within 21 days. Thank you for your contributions.

@stale stale bot added the stale label Nov 10, 2018
@stale stale bot closed this as completed Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant