Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZmqConnection.close should be a no-op #12

Closed
shs96c opened this issue Jan 7, 2019 · 1 comment
Closed

ZmqConnection.close should be a no-op #12

shs96c opened this issue Jan 7, 2019 · 1 comment

Comments

@shs96c
Copy link

shs96c commented Jan 7, 2019

javax.jms.Connection is AutoCloseable, so expected usage is in a try-with-resources block. This automatically calls close when leaving the block. The current implementation of ZmqConnection.close throws an UnsupportedOperationException. Making this a no-op (and potentially logging the problem?) would allow the expected JMS usage to work.
@shs96c shs96c mentioned this issue Jan 7, 2019
Closed
@mjeremym
Copy link
Member

Fixed in release 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shs96c @mjeremym