Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unix domain sockets under Win10 #3691

Closed
casabre opened this issue Sep 25, 2019 · 2 comments · Fixed by #3717
Closed

Support unix domain sockets under Win10 #3691

casabre opened this issue Sep 25, 2019 · 2 comments · Fixed by #3717

Comments

@casabre
Copy link

casabre commented Sep 25, 2019

Issue description

Hi there,
thanks for the great work but I have a feature request regarding unix domain sockets on Windows 10. According to the following blog article, Win10 supports now AF_UNIX domain sockets. If I use ipc://, a not supported socket type will be reported. Thus, could please extend the compatible Win10 sockets to AF_UNIX as well. The support of the utilized Win10 version can be checked by sc query afunix

Please see also #1327@pyzmq

Environment

  • libzmq version (commit hash if unreleased): 18.1
  • OS: Windows 10

Minimal test code / Steps to reproduce the issue

use pyzmq

import zmq
context = zmq.Context()
socket = context.socket(zmq.PUB)
socket.bind('ipc:///tmp/stream')

What's the actual result? (include assertion message & call stack if applicable)

Traceback (most recent call last):
File "", line 1, in
File "zmq\backend\cython\socket.pyx", line 550, in zmq.backend.cython.socket.Socket.bind
File "zmq\backend\cython\checkrc.pxd", line 25, in zmq.backend.cython.checkrc._check_rc
zmq.error.ZMQError: Protocol not supported

What's the expected result?

Bound or connected socket

@bluca
Copy link
Member

bluca commented Sep 25, 2019

This was discussed in #3507 and #3104 and #1808

Pull requests to implement support for this are welcome

@sigiesec
Copy link
Member

Indeed, Win10 supports AF_UNIX now. This will require some adaptations in libzmq, since this is still done via the Windows flavour of the socket API.

For the ipc transport this will probably work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants