Configuration should fail if --with-libsodium is specified and libsodium isn't present

[drewcrawford]

Rationale

I am tired of specifying "--with-libsodium", on a system with a bad / no libsodium install, and libzmq configuring, building, and installing without error, except a warning message buried in the middle of a verbose output. Then, I go to run my app, notice something is wrong, start debugging my app, and it turns out that libzmq did not build as I asked after all.

Reproduction steps

1. Clone master
2. Run ./autogen.sh
3. Run ./configure --with-libsodium

Expected output

checking for sodium_init in -lsodium... no
configure: ERROR: You don't have libsodium installed.  Install it or don't pass --with-libsodium
$ echo $?
1

Actual output

checking for sodium_init in -lsodium... no
configure: WARNING: libsodium is needed for CURVE security
checking whether C++ compiler supports -fvisibility=hidden... yes
checking whether C++ compiler supports dso visibility... yes
checking for asciidoc... no
checking for xmlto... no
..
$ echo $?
0

[hintjens]

Can you propose a patch to the configure.ac file for this?

On Mon, Mar 10, 2014 at 1:03 AM, Drew Crawford notifications@github.comwrote:

Rationale

I am tired of specifying "--with-libsodium", on a system with a bad / no
libsodium install, and libzmq configuring, building, and installing without
error, except a warning message buried in the middle of a verbose output.
Then, I go to run my app, notice something is wrong, start debugging my
app, and it turns out that libzmq did not build as I asked after all.
Reproduction steps

1. Clone master
2. Run ./autogen.sh
3. Run ./configure --with-libsodium

Expected output

checking for sodium_init in -lsodium... no
configure: ERROR: You don't have libsodium installed. Install it or don't pass --with-libsodium
$ echo $?
1

Actual output

checking for sodium_init in -lsodium... no
configure: WARNING: libsodium is needed for CURVE security
checking whether C++ compiler supports -fvisibility=hidden... yes
checking whether C++ compiler supports dso visibility... yes
checking for asciidoc... no
checking for xmlto... no
..
$ echo $?
0

Reply to this email directly or view it on GitHubhttps://github.com//issues/912
.