Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a definitive cygwin target for libzmq. #1283

Merged
merged 1 commit into from Jan 5, 2015

Conversation

DaiyuHurst
Copy link
Contributor

Hi folks!

Like the original poster here:

zeromq/pyzmq#113

I couldn't get a shared library built on cygwin with existing and past releases. The solution offered there worked but was really inelegant. I thought maybe a few hours work could correct that (some friends of mine are using 0mq for an emulator project and I'm helping ensure a Windows port exists).

The changes I offer create a working shared library for the cygwin environment, tested only on Cygwin64, but should work in Cygwin32 as well. They should not affect builds on any other targets.

All tests pass except for test_ipc_wildcard, which fails in bounce() trying to receive the message it sent itself. One other observation from extensive debugging through test_term_endpoint showed all the IPC stuff is working but the program hands trying to return(0); substituting exit(0) briefly fixed it, and my guess is that something is corrupting the stack, making it impossible for the program to return control to the caller. I do not include the modified test_term_endpoint, exit(0) is not a proper fix for a corrupted stack.

I'll be submitting parallel changes to czmq and zyre as well, and I'd appreciate any and all feedback on these proposed changes.

Thanks in advance!

@hintjens
Copy link
Member

Would you like to check zproject and see if you can make that work? We're aiming to replace the hand-built builds for czmq and zyre with that over time.

@DaiyuHurst
Copy link
Contributor Author

Sure! Might not get started on it until tomorrow tho...

Oh... a quick search on git failed to reveal it. Link?

@hintjens
Copy link
Member

It's here: https://github.com/zeromq/zproject

On Mon, Dec 29, 2014 at 11:57 PM, Daiyu Hurst notifications@github.com
wrote:

Sure! Might not get started on it until tomorrow tho...

Oh... a quick search on git failed to reveal it. Link?


Reply to this email directly or view it on GitHub
#1283 (comment).

@DaiyuHurst
Copy link
Contributor Author

Ok, got it forked and cloned.

@jemc
Copy link
Member

jemc commented Dec 29, 2014

For what it's worth, zyre skeleton is already generated by zproject.

@hintjens
Copy link
Member

I'd forgotten about that. :-)
On Dec 30, 2014 12:55 AM, "Joe Eli McIlvain" notifications@github.com
wrote:

For what it's worth, zyre skeleton is already generated by zproject.


Reply to this email directly or view it on GitHub
#1283 (comment).

@DaiyuHurst
Copy link
Contributor Author

Zyre builds fine under cygwin. I'll look at zproject; I assume the issue is not getting _it_to build on cygwin, but getting it to generate consistent build target scripts for cygwin?

@DaiyuHurst
Copy link
Contributor Author

How can I open a discussion about zProject? I've made cygwin changes but this seems the wrong place to discuss them or to ask questions.

@hintjens
Copy link
Member

You can discuss on zeromq-dev, for sure.

On Tue, Dec 30, 2014 at 5:17 PM, Daiyu Hurst notifications@github.com
wrote:

How can I open a discussion about zProject? I've made cygwin changes but
this seems the wrong place to discuss them or to ask questions.


Reply to this email directly or view it on GitHub
#1283 (comment).

@DaiyuHurst
Copy link
Contributor Author

One quick question about using gsl got zProject et. al.... here in my environment, it's outputting files that have \r\n terminators (CRLF) instead of just \n (LF). I should be able to change that by adding an attribute switch:

gsl -terminator:\n -q project.xml

but that just makes the letter 'n' the terminator, and \n makes it a literal ''\n" not a :LF char.

If you have been experiencing this, are you just post-editing the generated files to remove the carriage returns?

For now I will simply edit the generated files for my commit of the changes to zproject needed to generate cygwin build targets. I don't know how to test it though, it seems to need to be built for a specific project.

@hintjens
Copy link
Member

Easy to test: install zproject with your changes, then rebuild for zyre
("gsl project.xml" in zyre root dir).

On Tue, Dec 30, 2014 at 8:52 PM, Daiyu Hurst notifications@github.com
wrote:

One quick question about using gsl got zProject et. al.... here in my
environment, it's outputting files that have \r\n terminators (CRLF)
instead of just \n (LF). I should be able to change that by adding an
attribute switch:

gsl -terminator:\n -q project.xml

but that just makes the letter 'n' the terminator, and \n makes it a
literal ''\n" not a :LF char.

If you have been experiencing this, are you just post-editing the
generated files to remove the carriage returns?

For now I will simply edit the generated files for my commit of the
changes to zproject needed to generate cygwin build targets. I don't know
how to test it though, it seems to need to be built for a specific project.


Reply to this email directly or view it on GitHub
#1283 (comment).

hintjens added a commit that referenced this pull request Jan 5, 2015
Implement a definitive cygwin target for libzmq.
@hintjens hintjens merged commit 25f1539 into zeromq:master Jan 5, 2015
@bluca
Copy link
Member

bluca commented Aug 31, 2019

@DaiyuHurst could you please send a new pull request or an email with a relicense statement? As explained in https://github.com/zeromq/libzmq/blob/master/.github/CONTRIBUTING.md and https://github.com/zeromq/libzmq/tree/master/RELICENSE we are trying to relicense libzmq under MPL-2. Thank you!

@DaiyuHurst
Copy link
Contributor Author

DaiyuHurst commented Aug 31, 2019 via email

@bluca
Copy link
Member

bluca commented Aug 31, 2019

Thank you!

bluca added a commit to bluca/libzmq that referenced this pull request Aug 31, 2019
Received as Github comment:
zeromq#1283 (comment)
bluca added a commit to zeromq/libzmq-relicense that referenced this pull request Jun 5, 2023
Received as Github comment:
zeromq/libzmq#1283 (comment)

(cherry picked from commit 48c629088845ae0b3cd88415135bbf1c5ed21f11)
bluca added a commit to zeromq/libzmq-relicense that referenced this pull request Jun 7, 2023
Received as Github comment:
zeromq/libzmq#1283 (comment)

(cherry picked from commit 48c629088845ae0b3cd88415135bbf1c5ed21f11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants