Problem: can't unbind with bound addr with IPv6 #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: add helper function is_ipv6_available to testutil.hpp to test if IPv6 is available on the building platform. This function will try to open and bind a socket to ::1:*, as it's the ultimate way of knowing if, at least on the loopback, IPv6 is enabled.
Solution: add one test run in a docket container environment, which is currently the only environment where it's possibile to bind a socket to ::1.
Solution: try to resolve the TCP endpoint passed by the user in the zmq_unbind call before giving up, if it doesn't match. This fixes a breakage in the API, where after a call to zmq_bind(s, "tcp://127.0.0.1:9999") with IPv6 enabled on s would result in the call to zmq_unbind(s, "tcp://127.0.0.1:9999") failing. Add more test cases to increase coverage on all combinations of TCP endpoints.
bluca
force-pushed
the
zmq_unbind_api_breakage
branch
from
89592cf
to
c8211bf
Compare
|
Backported to 4.1: zeromq/zeromq4-1#118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: un-break un-binding a socket with the same endpoint string that was used to bind it when IPv6 is enabled. The breakage was caused by using the actual last_endpoint as a key instead of the string passed by the user, which is necessary in the wildcard case. But it broke the normal case with IPv6, since even if the address is an IPv4 one it will be saved in IPv6 format, so it doesn't match anymore. This is the culprit: 09e7416
My solution is a liiitle bit of a hack - basically I try to use the used-provided endpoint string and resolve it, just like it's used in connect/bind case, and see if that succeeds before giving up. At least it should be future-proof, and if more changes are done to the connect/bind they should be picked up in the unbind/disconnect. And the existing API for wildcard sockets is maintained, nothing is broken.
Also added a bunch of tests for various combinations of TCP sockets endpoints. Note that Travis on Precise (legacy) or Trusty does not support IPv6, so I added a test run on the container-based environment which is the only one that has a loopback interface with ::1 bound on it, so IPv6 test cases can run there. Note that I can't test this on Windows - I think it should work as I've used the same options as in existing part of the library.
Fixes zeromq/zeromq4-1#114