Problem: supported protocols comment is stale #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Fix it and align with the documentation; zmq_socket_monitor(3) outlines that ZMQ socket monitoring is supported for TCP, IPC and TIPC.
|
@bluca I find phrasing the latter in Problem/Solution format to be a little problematic at times. :-) |
|
Thanks! |
|
Commits too :-) It helps making it clear what you are doing, and it's very helpful to build the changelog |
|
Drat. OK. Hint hint @somdoron, or maybe he gets the BDFL free pass. :-) |
|
I will do it too :-) no free pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Fix it by aligning with the documentation; zmq_socket_monitor(3) outlines that ZeroMQ socket monitoring is supported for TCP, IPC and TIPC.