problem: srcfd is broken and unneeded as we have metadata #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,8 +86,7 @@ int zmq::msg_t::init () | |||
| u.vsm.flags = 0; | |||
| u.vsm.size = 0; | |||
| u.vsm.group[0] = '\0'; | |||
| u.vsm.routing_id = 0; | |||
| u.vsm.fd = retired_fd; | |||
| u.vsm.routing_id = 0; | |||
There was a problem hiding this comment.
there's trailing whitespace here and in other places below - want to fix before merge? or in a new PR?
There was a problem hiding this comment.
I will fix it, this is what happen when I'm using visual studio :-(
| @@ -137,8 +134,7 @@ int zmq::msg_t::init_external_storage(content_t* content_, void* data_, size_t s | |||
| u.zclmsg.flags = 0; | |||
| u.zclmsg.group[0] = '\0'; | |||
| u.zclmsg.routing_id = 0; | |||
| u.zclmsg.fd = retired_fd; | |||
|
|
|||
|
|
|||
|
@bluca should be good now |
somdoron
changed the title
|
Mmh OSX (or rather Clang) is not happy: Do you have Clang available to give it a look? |
|
I have osx vm, checking... |
|
fixed #1954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR solve the broken SRCFD by using metadata to store the file descriptor.
However as we now have metadata which include the peer address we don't need the SRCFD, therefore marked SRCFD as deprecated. If someone need more metadata I suggest adding it instead of using the SRCFD.
Fixes #1950