Restore /dev/poll support #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Make devpoll_t derive from worker_poller_base_t
Solution: Remove _worker
|
Thanks a lot for fixing this, and sorry it broke without notice! Unfortunately, we don't have any Solaris CI. Recently, I added some information on supported platforms here: https://github.com/zeromq/libzmq/blob/master/README.md#supported-platforms-with-known-active-users As you seem to be a "known user" on Solaris, could you perhaps add an entry here with your exact platform data? |
Solution: Add Solaris 10 to the list
|
@sigiesec Added as requested. |
|
@jacquesg Thanks a lot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore support for
/dev/pollon Solaris, remove one unused class variable fromepoll_t.