Update array.hpp

[xqcool]

Problem:Calling back on an empty container causes undefined behavior.
Solution:Check with the function empty()

[bluca]

Thanks for the PR - please add a commit with a relicense statement https://github.com/zeromq/libzmq/blob/master/RELICENSE/README.md

[xqcool]

Thanks for the PR - please add a commit with a relicense statement https://github.com/zeromq/libzmq/blob/master/RELICENSE/README.md

OK.

[sigiesec]

You are right that calling back on an empty container has undefined behaviour, but this is not a legal use of array::erase anyway. Rather than changing the condition, the if should be removed entirely, or changed into zmq_assert (!_items.empty()); or rather zmq_assert (items.size() > index_);

[xqcool]

OK，Your suggestion is more in line with zmq design，thank for you 发送自 Windows 10 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>应用 发件人: Simon Giesecke<mailto:notifications@github.com> 发送时间: 2020年1月6日 23:12 收件人: zeromq/libzmq<mailto:libzmq@noreply.github.com> 抄送: xqcool<mailto:xuquan316@live.com>; Author<mailto:author@noreply.github.com> 主题: Re: [zeromq/libzmq] Update array.hpp (#3769) You are right that calling back on an empty container has undefined behaviour, but this is not a legal use of array::erase anyway. Rather than changing the condition, the if should be removed entirely, or changed into zmq_assert (!_items.empty()); or rather zmq_assert (items.size() > index_); ― You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3769?email_source=notifications&email_token=AHVTZ2BADKJWNATMGFNCQLTQ4NC6TA5CNFSM4KBTAVQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIFXC5I#issuecomment-571175285>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHVTZ2GHINRPM64QT6HZL4DQ4NC6TANCNFSM4KBTAVQQ>.