Manually disable symbol export #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
16 tasks
bluca
reviewed
Oct 6, 2021
|
Not sure what's going on with that pending build, is that OBS? |
auto-merge was automatically disabled
October 7, 2021 07:37
Head branch was pushed to by a user without write access
|
Ah, force pushing a non-changed amended commit apparently doesn't retrigger CI, still stalling :) Could you restart it? |
…remain invisible to users of my library. There is no way to control this, since visibility is set automatically through ZMQ_EXPORT based on OS and compiler.
Solution: add a preprocessor variable ZMQ_NO_EXPORT that, when set, bypasses the automatic ZMQ_EXPORT determination block and just sets ZMQ_EXPORT to empty.
By combining this solution at configuration time with manually passing -fvisibility=hidden to CXXFLAGS, I solved my visibility problem. Just passing -fvisibility=hidden is not enough, because __attribute__ ((visibility ("default"))) has higher priority.
|
I rebased into one commit, but still doesn't seem to trigger the OBS builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when linking to libzmq in my project, I want zmq symbols to remain invisible to users of my library. There is no way to control this, since visibility is set automatically through
ZMQ_EXPORTbased on OS and compiler.Solution: add a preprocessor variable
ZMQ_NO_EXPORTthat, when set, bypasses the automaticZMQ_EXPORTdetermination block and just setsZMQ_EXPORTto empty.By combining this solution at configuration time with manually passing
-fvisibility=hiddentoCXXFLAGS, I solved my visibility problem. Just passing-fvisibility=hiddenis not enough, because__attribute__ ((visibility ("default")))has higher priority.