Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: merged pr-4432 broke FindSodium on linux #4542

Merged
merged 2 commits into from
Apr 22, 2023

Conversation

bjornstromberg
Copy link
Contributor

Solution: rename the FindSodium to Findsodium so it matches what the build script actually looks for. tested on ubuntu-20.04lts with cmake 3.16.

Solution: rename the FindSodium to Findsodium so it matches what the build script actually looks for. tested on ubuntu-20.04lts with cmake 3.16.
Solution: added relicense agreement
@bjornstromberg
Copy link
Contributor Author

#4432 just to link these

@bjornstromberg bjornstromberg marked this pull request as ready for review April 22, 2023 07:18
@bjornstromberg
Copy link
Contributor Author

bjornstromberg commented Apr 22, 2023

the ci failure on the github actions ci is just a long running test that timed out
70/101 Test #70: test_security_curve ..............***Timeout 60.01 sec

on master
70/101 Test #70: test_security_curve .............. Passed 11.74 sec

that is a pretty bad change, is this normal on github actions that stuff times out?
thinking load on server could be a big factor since everything else seems to have passed.

and no code is actually changed just a filename..

@bluca bluca merged commit 532b612 into zeromq:master Apr 22, 2023
15 of 16 checks passed
@bjornstromberg bjornstromberg deleted the libzmq-patch-pr-4432 branch April 22, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants