Add missing pkg_config_defines when built with CMake #4545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pkg_config_defines variable was only set in configure.ac, but not in CMake. This lead to the `-DZMQ_BUILD_DRAFT_API=1` flag to be omitted from the generated pkg-config file. Signed-off-by: Nicolas Benes <nbenes.gh@xandea.de>
|
Please add a relicense statement https://github.com/zeromq/libzmq/tree/master/RELICENSE |
Signed-off-by: Nicolas Benes <nbenes.gh@xandea.de>
panicgh
added a commit
to panicgh/libzmq
that referenced
this pull request
May 16, 2023
PR zeromq#4545 sets `pkg_config_defines` too late, i.e. after the pkg-config file is already generated. It must be set before `configure_file`.
panicgh
added a commit
to panicgh/libzmq
that referenced
this pull request
May 16, 2023
PR zeromq#4545 sets `pkg_config_defines` too late, i.e. after the pkg-config file is already generated. It must be set before `configure_file`.
bluca
pushed a commit
that referenced
this pull request
May 16, 2023
PR #4545 sets `pkg_config_defines` too late, i.e. after the pkg-config file is already generated. It must be set before `configure_file`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pkg_config_defines variable was only set in configure.ac, but not in CMake. This lead to the
-DZMQ_BUILD_DRAFT_API=1flag to be omitted from the generated pkg-config file.configure.ac contains this to set the variable accordingly:
libzmq/configure.ac
Lines 1056 to 1063 in 532b612