Fallback to hostname resolution in TCP and UDP. #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is done after interface resolution, so it can always be enabled to have a fallback mecanism on hostname resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the needs behind the issue #4514 by enabling fallback to hostname resolution if interface resolution fails.
When resolving addresses, there is already a fallback to getaddrinfo when interface resolution fails.
When allow_dns is set to false, the AI_NUMERICHOST flag is added to getaddrinfo to disable hostname resolution.
The fact we are binding is currently used to disable hostname resolution in TCP and UDP. To enable the fallback to hostname resolution, the allow_dns option should be set to true in all cases.