halt build if CURVE requested but not found #4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENABLE_CURVE is currently redundant with WITH_LIBSODIUM, as the only existing provider now builds where requested configuration is not found fail rather than proceeding without requested features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: It's frustrating to attempt to build libzmq with curve, only to find out after build has completed that it wasn't found and the request was ignored.
Solution: respect user input and fail if their choice cannot be satisfied instead of ignoring it.
now builds where requested configuration is not found fail rather than proceeding without requested features
changes:
Previously, to enable curve, you needed the redundant config:
Whereas the following would not attempt to enable CURVE:
and the required configuration would also proceed to build without CURVE, ignoring user request with a message.
Since ENABLE_CURVE and WITH_LIBSODIUM really represent the same thing now (there is no CURVE without sodium), we could also deprecate one or default it to True. But this is the smallest change.