Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rawset when initializing child thread args #34

Merged
merged 1 commit into from
Mar 31, 2015

Conversation

johnfoconnor
Copy link

it is possible for someone to mess with the global table in the prelude or lua_init phases of thread creation. For instance, one could disable the creation of global variables via the _G __newindex metatable method. Then the thread spawning code would not work correctly. For this reason we should not rely on normal insertion into _G and instead use rawset

@buildhive
Copy link

The ØMQ project » lzmq #52 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 64.52% when pulling 322ab86 on johnfoconnor:master into e1ca8e1 on zeromq:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 64.52% when pulling 322ab86 on johnfoconnor:master into e1ca8e1 on zeromq:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.55% when pulling 322ab86 on johnfoconnor:master into e1ca8e1 on zeromq:master.

moteus added a commit that referenced this pull request Mar 31, 2015
use rawset when initializing child thread args
@moteus moteus merged commit e626dbc into zeromq:master Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants