may be a bug #19

Closed
chenbk85 opened this Issue Sep 6, 2012 · 1 comment

Comments

Projects
None yet
2 participants

chenbk85 commented Sep 6, 2012

hi,
May be a bug in /libmdp/src/mdp_broker.c
static void
s_broker_worker_msg (broker_t *self, zframe_t *sender, zmsg_t *msg)
{
... ...
free (command); //! this only free, but not close message, should be zframe_destroy(&command)?
zmsg_destroy (&msg);
}

by the way, for worker/client commands, why not use one byte to instead of string(four bytes).
And one time only use one zmq_msg_t may be better, which not need to malloc frequently.

ths

chen baokai

Contributor

akitada commented Mar 30, 2013

Fixed.

akitada closed this Mar 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment