Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

may be a bug #19

Closed
chenbk85 opened this issue Sep 6, 2012 · 1 comment · Fixed by #37
Closed

may be a bug #19

chenbk85 opened this issue Sep 6, 2012 · 1 comment · Fixed by #37

Comments

@chenbk85
Copy link

chenbk85 commented Sep 6, 2012

hi,
May be a bug in /libmdp/src/mdp_broker.c
static void
s_broker_worker_msg (broker_t *self, zframe_t *sender, zmsg_t *msg)
{
... ...
free (command); //! this only free, but not close message, should be zframe_destroy(&command)?
zmsg_destroy (&msg);
}

by the way, for worker/client commands, why not use one byte to instead of string(four bytes).
And one time only use one zmq_msg_t may be better, which not need to malloc frequently.

ths

chen baokai

@akitada
Copy link
Contributor

akitada commented Mar 30, 2013

Fixed.

@akitada akitada closed this as completed Mar 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants