Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous integration testing #13

Merged
merged 7 commits into from
Dec 1, 2013
Merged

Add continuous integration testing #13

merged 7 commits into from
Dec 1, 2013

Conversation

claws
Copy link
Member

@claws claws commented Nov 29, 2013

This pull request provides initial continuous integration testing based on the same Travis-ci tool used by the czmq project.

I initially tried to get builds working for Python 2.6, 2.7, 32, 3.3 and pypy. The 2.7 build worked fine.

I had to make some simple changes to support 2.6. These involves adding the specific index to the {} in all string .format calls.

I tried to get the Python 3 based builds going. The first problem encountered was related to relative imports which meant I had to add a "." to some of the module import lines so that Python3 could import them. Next were the typical strings related issues with a 2to3 conversion. I decided not to implement these as it would be a large change set and that is perhaps better suited to a specific change set that adds Python 3 compatibility. I left the absolue module reference change in as it backward compatible and gets us closer to Python 3 compatibility.

I also tried to get the pypy build working but encountered issues with cffi where it was reporting problems returning 'void *' types. Again, I think this type of perhaps largish compatibility change would be better done under a separate change set to this CI focused change.

So what we are left with is a working continuous integration solution supporting Python 2.6 and 2.7 which I think is a good start. From here we can begin to address outstanding compatibility issues if and when needed.

IMPORTANT:
If you choose to merge this change then there are a few things you will need to do during the merge step to properly integrate this change set:

  1. You will need to create an account on Travis-ci.org (make sure you use the .org site not the .com site). This is easy as you can sign in using your Github account via OAuth.
  2. Once signed in to Travis-ci select 'Accounts' from your profile drop-down at top right.
  3. In the Repositories tab you will need to enable zeromq/pyczmq repo. This will set up a service hook within the Github zeromq/pyczmq project so that a commit will trigger a Travis-ci build.
  4. Modify the build status badge link in the README.md file as it currently references my claws/pyczmq project which was required for testing this change set. Change it to zeromq/pyczmq.

michelp added a commit that referenced this pull request Dec 1, 2013
Add continuous integration testing
@michelp michelp merged commit ad07321 into zeromq:master Dec 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants