Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keys directory #1624

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix keys directory #1624

wants to merge 1 commit into from

Conversation

mortezasaki
Copy link

The keys are not in the certificate directory

@minrk
Copy link
Member

minrk commented Oct 11, 2021

I think the directories are doing what they mean to (there's the original certificates directory, whose contents are populated by the generate_certificates utility, but that is reorganized into sibling private/public key dirs).

If anything's missing, it's perhaps the removal of the temporary certificates directory, which is empty after running generate_certificates.py. What do you think?

@mortezasaki
Copy link
Author

I agree with what you say. The certificates directory is empty after executing generate_certificates.py, and the public and private directories are created outside of this directory.

@minrk
Copy link
Member

minrk commented Oct 12, 2021

If you want to update the PR to remove the empty dir instead, I'd be happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants