Update wheels.yml to prevent release if failed builds. #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check for all wheels building successfully before uploading to PyPI. Not sure if this step should happen immediately after wheel building step or where I have put it?
1 task
markclare1992
changed the title
markclare1992
changed the title
|
Linked to #1978 |
|
Thanks for the PR! This is already accomplished by the If we added a step that pulled the wheels in from Circle so that only GitHub did the upload, it would fix this. |
|
#1982 causes all wheels to be uploaded together |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for all wheels building successfully before uploading to PyPI. Not sure if this step should happen immediately after wheel building step or where I have put it?