Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: config handling doesn't match supplied config #21

Closed
rpedde opened this issue Mar 25, 2014 · 2 comments
Closed

Problem: config handling doesn't match supplied config #21

rpedde opened this issue Mar 25, 2014 · 2 comments

Comments

@rpedde
Copy link
Contributor

rpedde commented Mar 25, 2014

Not sure how you actually wanted it formatted. I have a fix that approaches the config sample as supplied here:

https://github.com/rpedde/zproto/compare/zeromq:master...master

But I'm not sure if that's what you were actually shooting for.

@hintjens
Copy link
Member

That looks awesome. :-)

@rpedde
Copy link
Contributor Author

rpedde commented Mar 25, 2014

i pr-ed it as zeromq/zproto#37, but forgot to add a close annotation. whoops.

@rpedde rpedde closed this as completed Mar 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants