Fix for Electron v21 and up. #532
Conversation
| @@ -51,7 +52,6 @@ | |||
| ], | |||
|
|
|||
| 'defines': [ | |||
| 'NAPI_VERSION=3', | |||
There was a problem hiding this comment.
Doesn't removing this cause issues?
There was a problem hiding this comment.
I don't think so, as now <node_version.h> is included, which defines NAPI_VERSION...
If I didn't remove this, I got a compilation error that NAPI_VERSION was being redefined.
|
I think we should add some Electron tests as well. This way we cannot catch such errors. |
|
Agreed, as it is a runtime crash, it is very hard to catch. |
|
Hey guys, @aminya I took the time to check @sophacola 's profile. I think it's a bot. |
|
@sophacola : does it cause issues then? Strange Issue you created without any info in it... |
|
@sophacola oops! my apologies: being a 3-day account with 60 reviews triggered my alarms. |
|
@Bartel-C8 do you know @sophacola ? |
|
Just blocked and reported them for spam |
Fixes #514
NAPI_VERSION is defined in <node_version.h>