zmq_msg_move called on uninitialised message in xrep_t::xrecv -- fixed

zeromq · Sep 30, 2010 · 79aea5f · 79aea5f
1 parent c1deb22
commit 79aea5f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -24,6 +24,7 @@ Martin Hurton <hurtonm@gmail.com>
 Martin Lucina <mato@kotelna.sk>
 Martin Sustrik <sustrik@250bpm.com>
 Matus Hamorsky <mhamorsky@gmail.com>
+Max Wolf <YIDIEPXGXGPN@spammotel.com>
 McClain Looney <m@loonsoft.com>
 Mikael Helbo Kjaer <mhk@designtech.dk>
 Pavel Gushcha <pavimus@gmail.com>

diff --git a/src/xrep.cpp b/src/xrep.cpp
@@ -190,16 +190,17 @@ int zmq::xrep_t::xsend (zmq_msg_t *msg_, int flags_)
 
 int zmq::xrep_t::xrecv (zmq_msg_t *msg_, int flags_)
 {
-    //  Deallocate old content of the message.
-    zmq_msg_close (msg_);
-
+    //  If there is a prefetched message, return it.
     if (prefetched) {
         zmq_msg_move (msg_, &prefetched_msg);
         more_in = msg_->flags & ZMQ_MSG_MORE;
         prefetched = false;
         return 0;
     }
 
+    //  Deallocate old content of the message.
+    zmq_msg_close (msg_);
+
     //  If we are in the middle of reading a message, just grab next part of it.
     if (more_in) {
         zmq_assert (inpipes [current_in].active);