Fix bug in connecter #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connecter used EAGAIN to signal that the connection couldn't be completed immediately. But the same value was used by connect(2) to signal that it failed. This made it impossible for the connecter to distinguish between these conditions. The patch modifies the connecter to use EINPROGRESS value, as originally returned by connect(2). Another problem addressed by the patch is the situation when a connection could not be completed immediately with the IPC transport. The patch modifies the connecter so that it behaves similarly to TCP transport. Refs. https://zeromq.jira.com/browse/LIBZMQ-381
dvj
pushed a commit
to prismskylabs/zeromq2-x
that referenced
this pull request
Sep 2, 2014
Bumped version for next release
dvj
pushed a commit
to prismskylabs/zeromq2-x
that referenced
this pull request
Sep 2, 2014
ARM toolchain compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connecter used EAGAIN to signal that the connection
couldn't be completed immediately. But the same value was
used by connect(2) to signal that it failed. This made it
impossible for the connecter to distinguish between these
conditions.
The patch modifies the connecter to use EINPROGRESS value,
as originally returned by connect(2).
Another problem addressed by the patch is the situation
when a connection could not be completed immediately
with the IPC transport. The patch modifies the connecter
so that it behaves similarly to TCP transport.
Refs. https://zeromq.jira.com/browse/LIBZMQ-381