Remove unnecessary allocations and unsafe #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwhitehead
commented
Jul 14, 2022
| @@ -46,27 +53,29 @@ impl ZmqCommand { | |||
| } | |||
| } | |||
|
|
|||
| impl TryFrom<BytesMut> for ZmqCommand { | |||
| impl TryFrom<Bytes> for ZmqCommand { | |||
There was a problem hiding this comment.
Switched to Bytes for consistency
andrewwhitehead
commented
Jul 14, 2022
| let command_len = buf.get_u8() as usize; | ||
| // command-name-char = ALPHA according to https://rfc.zeromq.org/spec:23/ZMTP/ | ||
| let command_name = | ||
| unsafe { String::from_utf8_unchecked(buf.split_to(command_len).to_vec()) }; |
There was a problem hiding this comment.
This is UB given that the peer may not be following the spec.
|
Mostly LGTM. Could you please fix clippy error that pops in CI? |
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
fix/remove-allocs
branch
from
e9b2302
to
502cec9
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
fix/remove-allocs
branch
from
70b30e8
to
ec01c05
Compare
poyea
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.