SocketType cleanups #165
Merged
SocketType cleanups #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwhitehead
force-pushed
the
adj-socket-type
branch
from
48fa1d1
to
e640efd
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
adj-socket-type
branch
from
e640efd
to
2cd972a
Compare
|
Is there an issue with this PR? It's currently blocking my update of the greeting exchange for authentication support (mostly just the TryFrom part). |
|
Sorry but I'm again busy with killing russians. @poyea would have to take care of this. |
|
Hi,
Sorry I'm kind a busy fighting russians, so @poyea would have to take care
of it.
Regards, Alexei
…On Fri, Sep 9, 2022, 21:09 Andrew Whitehead ***@***.***> wrote:
Is there an issue with this PR? It's currently blocking my update of the
greeting exchange for authentication support (mostly just the TryFrom part).
—
Reply to this email directly, view it on GitHub
<#165 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHMAA2FWBF2Z6CCYEHSR4DV5N4PDANCNFSM56MYT5YQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enum-primitive-deriveandnum-traitsdependenciessockets_compatibleto a methodFromStrimplementation and support parsing from bytes