Fix hanging on repeated cross-site requests #260
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain sites (ZeroBlog++ in particular) seem to be very keen on trying to reload cross-site requrested images, which leads to 0net hanging until those requests are dropped. Thus we revert to returning error on bad requests. NOTE: user privacy should be considered
|
Maybe related to #263 I see this problem on main page console (after installing on Yggdrasil/remote node): Working menu only, the body is blank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain sites (ZeroBlog++ in particular) seem to be very keen on trying to reload cross-site requrested images, which leads to 0net hanging until those requests are dropped. Thus we revert to returning error on bad requests.
NOTE: user privacy should be considered, DO NOT merge before checking that no more info about local zeronet is leaked