Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing throw specifier #15

Closed
smlu opened this issue Jun 27, 2023 · 0 comments · Fixed by #29
Closed

Missing throw specifier #15

smlu opened this issue Jun 27, 2023 · 0 comments · Fixed by #29
Labels
bug Something isn't working

Comments

@smlu
Copy link
Member

smlu commented Jun 27, 2023

Code which parses AAPublicKey from bytes is missing multiple throw specifiers at places throwing EfParseError: https://github.com/ZeroPass/dmrtd/blob/master/lib/src/crypto/aa_pubkey.dart#L36-L62.

TODO: Replace EfParseError exception with general parser exception and catch & re-throw this exception inEfDG15 as EfParseError.
@smlu smlu added the bug Something isn't working label Jun 27, 2023
@smlu smlu mentioned this issue May 29, 2024
Merged
@smlu smlu closed this as completed in #29 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing throw specifier ZeroPass/dmrtd
1 participant
@smlu