-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid.isosurface for complex values? #709
Comments
@pfebrer should we warn about complex data-type, and then only pass the float, or simply accept the warning that arises? |
Hmm interesting, do complex value iso surfaces even make sense? Can you say that some complex value is larger/smaller than another? You would have to compute some real number out of them (e.g. the modulus) and then compute an isosurface for that, right? If that's the case, I think a warning from our side wouldn't solve much. We could either keep the scikit-image warning or raise an error (which maybe is the best option). |
Yeah, probably the modulus would be the best thing, shouldn't we then silently do that for a complex grid?
Or would you do something else? |
I'm not sure if we should do anything silently 😅 In any case, I would do it only if the isosurface level requested by the user is also a complex value, so that we are more certain that this is what the user wants to do. Otherwise I would raise an error. |
Asking for a complex isosurface would be horrendous :) |
Describe the bug
Currently when doing
Grid.isosurface
it truncates the complex part. So it might be rather difficult for end users to see this.scikit-image
is (I think) keeping the floats, and it might be a long time to allow complex values scikit-image/scikit-image#4308The text was updated successfully, but these errors were encountered: