Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EthernetTap does not shut down properly #7

Closed
adamierymenko opened this issue Jul 9, 2013 · 0 comments
Closed

EthernetTap does not shut down properly #7

adamierymenko opened this issue Jul 9, 2013 · 0 comments
Assignees
@adamierymenko
Labels
Type: Bug Bug to be resolved

Comments

@adamierymenko
Copy link
Contributor

When ZeroTier One exits, EthernetTap often hangs or does not shut down properly. On OSX this can actually cause the process to become a zombie in permanent "exiting" state. Currently working on this.
@ghost ghost assigned adamierymenko Jul 9, 2013
adamierymenko added a commit that referenced this issue Jul 9, 2013
@adamierymenko
Several things:
ef3e319 
(1) Probable fix for issue #7 and major cleanup of EthernetTap code with consolidation for all unix-like systems and specialization for different flavors only when needed.

(2) Refactor of Buffer<> to make its members private, and Packet to use Buffer's methods exclusively to access them. This improves clarity and means we're no longer lying about Buffer's role in the code's security posture.

(3) Add -fstack-protect to Makefile to bounds check stack variables.
@adamierymenko adamierymenko mentioned this issue May 12, 2015
Closed
@bobbyvinon bobbyvinon mentioned this issue Jul 12, 2017
Closed
@joseph-henry joseph-henry mentioned this issue Jan 4, 2018
Closed
@andrejbinder andrejbinder mentioned this issue Dec 15, 2021
Merged
adamierymenko added a commit that referenced this issue Nov 7, 2022
@adamierymenko
Merge pull request #7 from zerotier/tests
897aa11 
Tests
@Scobber Scobber mentioned this issue Jul 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamierymenko adamierymenko

Labels
Type: Bug Bug to be resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamierymenko