Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rules engine evaluation quirks #2214

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix rules engine evaluation quirks #2214

merged 2 commits into from
Mar 1, 2024

Conversation

laduke
Copy link
Contributor

@laduke laduke commented Feb 1, 2024

closes #2200

See issue for all the complicated explanation.

@laduke laduke added this to the 1.14.0 milestone Feb 9, 2024
@laduke laduke self-assigned this Feb 9, 2024
@laduke
Fix rules engine quirks
0bf67bf 
See #2200

Mostly makes Tag based rules work as expected
@laduke
Printfs for rules debugging
bca650e 
re-uses ZT_TRACE to enable.
@laduke laduke changed the base branch from main to dev February 29, 2024 18:41
joseph-henry
joseph-henry approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@joseph-henry joseph-henry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and can confirm it works as advertised and I agree with your reasoning. I think this is ready to be merged.

@laduke
Copy link
Contributor Author

laduke commented Mar 1, 2024

thanks for testing!

@laduke laduke merged commit 1dff0c6 into dev Mar 1, 2024
5 checks passed
@laduke laduke deleted the tl-tags-3 branch March 1, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-henry joseph-henry joseph-henry approved these changes

Assignees

@laduke laduke

Labels
None yet
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Obscure rules evaluation quirks
2 participants
@laduke @joseph-henry