Unstable api fixes #2232
Merged
Unstable api fixes #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laduke
force-pushed
the
unstable-api-fixes
branch
from
358d7f6
to
9e406dc
Compare
laduke
force-pushed
the
unstable-api-fixes
branch
from
9e406dc
to
965e630
Compare
it was counting incorrectly in some cases and returning empty objects. Basically just handling if network data is null
It was returning an array of array instead of just array
laduke
force-pushed
the
unstable-api-fixes
branch
from
75fcc43
to
6e8fcce
Compare
joseph-henry
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was testing again zerotier-one-api-spec and found some small fixes