Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition where active-backup would fail to engage #2252

Merged
merged 1 commit into from Mar 14, 2024

Conversation

joseph-henry
Copy link
Contributor

In some cases links in a bond wouldn't be marked as bonded resulting in the bonding mode not registering itself as ready. This then results in an active bonding layer that appears to be working when in fact only the classical path handling logic is running.

This can be tested with local.conf similar to (with correct interface names of course):

{
  "settings":
  {
    "allowSecondaryPort": false,
    "defaultBondingPolicy": "rapid-active-backup",
    "policies":
    {
      "rapid-active-backup":
      {
        "basePolicy": "active-backup",
        "failoverInterval": 1000,
        "links":
          {
            "enp7s0": { "failoverTo": "eth0", "mode": "primary" },
            "eth0": { "mode": "spare" }
          }
      }
    }
  }
}

When a cable is pulled:

  • What did happen: Sometimes the bond would report using a link when in fact it was using another and then fail to... faillover
  • What it does now: Use correct link and failover

@joseph-henry joseph-henry added this to the 1.14.0 milestone Mar 14, 2024
@joseph-henry joseph-henry marked this pull request as ready for review March 14, 2024 18:43
Copy link
Contributor

@laduke laduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we tested across our computers and it worked

@joseph-henry joseph-henry merged commit acaebbd into dev Mar 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants