This repository has been archived by the owner on Oct 23, 2018. It is now read-only.
Add pattern permitted params #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.name.chomp('PermittedParams').singularize.constantize | ||
| rescue NameError | ||
| self.name.chomp('PermittedParams').split('::').last.singularize.constantize | ||
| end |
There was a problem hiding this comment.
end at 7, 4 is not aligned with def at 3, 2
|
@silviolrjunior Can you rebase this please? The build issues were unrelated to the project code. All i had to fix were the simplecov being loaded in ruby 1.8.7. 🍻 |
| @@ -33,12 +33,16 @@ def edit | |||
| end | |||
|
|
|||
| def create | |||
| instance_variable_set("@#{service.interface_name}", service.create(params)) | |||
| permitted_params = "::#{self.class.name.chomp('Controller').concat('PermittedParams')}".constantize.new(params).create rescue nil | |||
There was a problem hiding this comment.
Avoid using rescue in its modifier form.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
plribeiro3000
added a commit
that referenced
this pull request
Aug 4, 2014
Add pattern permitted params
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.